Skip to content

fix(rust): do not crash on empty vectors in IpConfig#2371

Merged
imobachgs merged 2 commits intomasterfrom
optional-ipconfig-vectors
May 19, 2025
Merged

fix(rust): do not crash on empty vectors in IpConfig#2371
imobachgs merged 2 commits intomasterfrom
optional-ipconfig-vectors

Conversation

@imobachgs
Copy link
Copy Markdown
Contributor

Problem

The "agama events" might crash with the following error:

Error: missing field `dnsSearchlist`

Solution

Use a default value for the vector in IpConfig.

Testing

  • Tested manually

@coveralls
Copy link
Copy Markdown

coveralls commented May 19, 2025

Coverage Status

coverage: 62.83% (-26.1%) from 88.891%
when pulling cf2babb on optional-ipconfig-vectors
into d3a8b71 on master.

Copy link
Copy Markdown
Contributor

@teclator teclator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imobachgs imobachgs merged commit c008d8f into master May 19, 2025
8 checks passed
@imobachgs imobachgs deleted the optional-ipconfig-vectors branch May 19, 2025 14:22
@imobachgs imobachgs mentioned this pull request May 26, 2025
imobachgs added a commit that referenced this pull request May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants